Kristian Duske

Results 319 comments of Kristian Duske

Besides that, @EludeQ, what's the status of this PR? It's slated to be included in the next milestone and I think everything else is done.

> > Besides that, @EludeQ, what's the status of this PR? It's slated to be included in the next milestone and I think everything else is done. > > Not...

I saw that you are passing ´aiProcess_MakeLeftHanded` to `ReadFile` - that can't be right; TB is using a right handed coordinate system. Could that be the problem?

Don't feel bad, I missed it, too. I only noticed after reading about this option in the docs and thinking, hey, are we passing this option maybe? I better double...

I'm going to merge this now. Any further problems can be addressed in separate issues or PRs.

Agree it‘s a good idea. I‘d vote for game config.

Are we going to restrict it to base 2 and base 10? I don't see why we should support other bases, but then I guess it wouldn't be any more...

I don't see us going as far as supporting different units.

@neogeographica you found the original bug, care to take a look at this PR?

See https://github.com/TrenchBroom/TrenchBroom/pull/4110#issuecomment-1265956634 This change makes it possible for actions that require a selection to be fired when there is no selection. That's not what we want.