IMSY-DKFZ
Seem impossible to simulate with different laser energies depending on the wavelength
Hi again,
Description
As I mentionned in the previous message, we observed in the system calibration that the laser energy was dependant on the wavelength, and that considering it constant was possibly an assumption to be refined. In the Tags.py, it is written that Tags.LASER_PULSE_ENERGY_IN_MILLIJOULE can be inputted as a int, array, list etc. but when I tried to launch a simulation with a list, a bug appeared, and it indeed seems that the calculations made in the optical simulation don't allow that. I however think that this could be a quite simple feature to be added (but I don't completely understand what it involves), if it is not already added (I could have missed something).
Priority
Medium
Yes, you're right. Here, we just take whatever value is set in the component_settings. So if there's an iterable given, this will not really works. But this is easily fixable by extracting the correct value from the iterable. If you want to open a pull request, you're very welcome! :)
Hi, Just a clean duplicate of Jeremies PR. But it would probably make sense to include it as some form of LaserCallibrationSpectrum into the PhotoacousticDevice instead of component_settings?
