Danny Lin

Results 38 comments of Danny Lin

The first two errors are caused by incompatible Node.js versions, but the last one looks like a bug. Please run it with `export DEBUG='*'` to get a stack trace.

This will break extraction from non-A/B images.

If the problem is that A/B isn't being detected on Android 13, this should be done properly by fixing the detection instead. Handling both A/B and A-only + non-system-as-root cases...

Sure, it's not a priority at the moment but feel free to contribute an optional lock step based on the unlock step. The main issue is that unlike unlocking, locking...

"New Live Space" is already enabled by default on stable Android 12. On-device search is a bit of a special case, so toggling it both ways shouldn't be expected to...

@thatcher-gaming That's a LineageOS bug caused by overriding `accent_device_default_light`, which should not be done on Android 12. Instead, ROMs should generate static Material You color palettes for their default accent...

Sure, that could be done, but can you explain why you feel that adjusting Okhsl saturation would be better for palette generation? For Material You, results have been good when...

This is the same issue as https://github.com/ksmet1977/luxpy/issues/17, but that doesn't seem to have been fixed.

By adapting the sample inputs with CAT02 parameters that match the example viewing conditions and leaving the reference white unadapted, our results are now much closer to the examples, but...

This does make sense, but it might increase the risk of negative power readings for low frequencies (which has already been an issue on some Exynos devices). It may be...