Kyle McCormick

Results 207 comments of Kyle McCormick

@robrap We've had to adjust the acceptance criteria here a bit. Rather than using Waffle flags, we'll be using Django settings. The reason for the change is that Waffle flags...

> Although this may be for good reasons, I'm simply clarifying the consequence that user-by-user or percentage-based rollout will no longer be available, and this will now be an all-or-nothing...

To be addressed: ![image](https://github.com/openedx/edx-platform/assets/3628148/21dc1767-5033-486c-bfaa-6e4bece6db79)

Also: ![image](https://github.com/openedx/edx-platform/assets/3628148/529df931-dc04-42d0-aa2d-ff9b8caf3e50)

@ormsbee @bradenmacdonald This is an updated take on [my first upstream_block ADR](https://github.com/openedx/edx-platform/pull/34322), plus what I learned from [actually implementing it](https://github.com/openedx/edx-platform/pull/34925), plus a new approach for limited customizability of downstream blocks.

@bradenmacdonald @ormsbee This is ready for re-review.

@bradenmacdonald Did you want to make another pass before I merge?

Thanks @CodeWithEmad !

@feanil In that case I'll edit my suggestions just to use the client ID that devstack.py provides