Kyle McCormick

Results 207 comments of Kyle McCormick

@BbrSofiane , I think @regisb is thinking of @ormsbee 's pymongo fix here? https://github.com/overhangio/tutor/pull/699

> Where “TYPE” is either “Bugfix”, “Improvement”, “Feature” or “Security”. You should add an explosion emoji (”💥”) before “[TYPE]” if you are making a breaking change. This is a breaking...

@regisb Carlos is just doing what we asked him to do :) From https://github.com/overhangio/2u-tutor-adoption/issues/26 : > In order to give folks time to stop using runserver, wait until Tutor v14...

@regisb I've re-opened this PR on top of nightly: https://github.com/overhangio/tutor/pull/718

@timmc-edx Welp, edx-platform already shamelessly uses [`crum`](https://pypi.org/project/django-crum/) to treat the current request as a global variable, so I imagine we could backwards-compatibly extend `in_preview_mode` to something like: ```python import crum...

> It seems like the hard part here (besides updating unit tests and such) would be figuring out how to convey a new preview_enabled course parameter while navigating in preview...

> Tutor could maybe simply flag an error if PREVIEW_LMS_HOST isn't a subdomain of LMS_HOST? Since I expect it'll be some time before the preview situation is improved (by changing...

Relates to https://github.com/openedx/build-test-release-wg/issues/138

@jmbowman I had started this work a few months ago, but abandoned it in order to focus on Tutor. You can see some of my progress and findings here: https://github.com/openedx/devstack/issues/869...

Nice. After I put [this plugin](https://github.com/overhangio/2u-tutor-adoption/issues/77#issuecomment-1276217825) up for review, I'll take a look at this.