Kyle McCormick

Results 207 comments of Kyle McCormick

@CodeWithEmad Thanks for the detailed report. I believe that collectstatic tries to recursively descend each installed packages' staticfiles directories in search of collectable assets. Docker cannot follow symlinks that point...

I have nothing to add beyond Regis's review--just want to say that this is a great idea and thank you for the contribution 👍🏻

Hi @tecoholic . I'm looking forward to this change! Looks like there are just a couple minor change requests left, and then we're good to merge this.

2U found an issue with 24.04 (which I don't yet understand) that led them to pin edx-platform tests back to 22.04: https://github.com/openedx/edx-platform/pull/35635 I'm going to ask them about it tomorrow...

FYI @farhan and @feanil . Once an extracted block is ready to go, I think this is how we should roll it out. Let me know if you disagree.

@farhan 1. My idea is that there is still just one entrypoint: ```python "word_cloud = xmodule.word_cloud_block:WordCloudBlock", ``` The point of the waffle flag is to swap between two different values...

@timmc-edx > Is the idea here that there is safety from data races because the waffle flag is loaded in the same transaction as the xblock DB accesses? Nope, I...

FYI @farhan @robrap -- I had originally said that we need CourseWaffleFlags so that individual course runs could switch back and forth between the blocks. I was wrong about that:...

@robrap as we discussed, I've added a note for the team to set a custom attribute. The key will be `block_extracted` and the values will be True, False, or None...

@robrap 1. Yep, understood, I had True-False-None because it was one less line of code, but since it sounds like True-False-N/A is actually better for monitoring, I've updated the ticket...