Csongor Kiss comments

Results 57 comments of


                                            Csongor Kiss

Using `Account<T>` with `owner` constraint ignores `owner` constraint

Right, something like that! > If so, how do you make sure this is going to be safe? Not sure I understand -- safety will be achieved through a combination...

build guardiand on an ARM mac M1 machine

it would be nice to be able to build at least development binaries on macs. one of the issues is that the celo bls package version that the guardian depends...

Standardize parse VAA methods across WH repo

looked at sdk/js/src/generic.ts, which looks very similar to the client parser, so happy to keep that one instead (although need to make sure it's up to date)

Standardize parse VAA methods across WH repo

I see that there's an alternative parsing method in the sdk next to generic.ts in the rest of the files. I for one don't like that interface that much, for...

aptos: upgrade `complete_transfer` to use `aptos_account::deposit_coins`

this feature is not yet available on mainnet (see the `coin` module under https://explorer.aptoslabs.com/account/0x1/modules), but agree with the change once it's available

sdk/js: catch-all catch blocks swallow exceptions

hey @Abhishekkochar, thanks! I don't believe anyone's actively working on this, so I'll assign the issue to you if you're interested in giving it a go

sdk/js: catch-all catch blocks swallow exceptions

You might have to fork the repo and push the branch to your own fork, then open a PR from there!