Csongor Kiss
Csongor Kiss
I'll close this, but feel free to reopen if you think further discussion is warranted!
Hey @a5-pickle, I'm starting to look over this PR. It's quite big, could you add a brief overview into the PR description about what it does and what's a good...
FWIW if you want to add a new CI action, you can do so by editing this file: https://github.com/wormhole-foundation/wormhole/blob/dev.v2/.github/workflows/build.yml
> const_panic has been stable since rust 1.57 so if we make this function (and `get_denom`) const then the panic will be a compile-time error rather than a runtime error....
When `t: MyType`, an alternative syntax could be ``` (&t).foo_immut(...) ``` and ``` (&mut t).foo_mut(...) ``` although slightly noisier, it has the advantage that it makes borrowing and mutable borrowing...
Current dependencies on/for this PR: * dev.v2 * **PR #1731** * **PR #1732** * **PR #1733** * **PR #1734** * **PR #1735** * **PR #1736** 👈 This comment was auto-generated...
Current dependencies on/for this PR: * dev.v2 * **PR #1731** * **PR #1732** * **PR #1733** * **PR #1734** * **PR #1735** * **PR #1736** 👈 This comment was auto-generated...
The toolchain does not produce deterministic builds, so the only way to have reproducible output is by building in a docker image. What would be a good alternative solution?
> Why the sub module? I believe @kcsongor has set up forge to avoid this yes, specifically set up the Makefile to avoid this, unfortunately there's currently (at least the...
Sure, the only reason I thought of this was that it requires nasty workarounds in Haskell, and it would be better if those two were called the same. Other than...