Csongor Kiss

Results 57 comments of Csongor Kiss

> The problem is `generic . stripMedatata . from generic` doesn't direct type inference. `tuple` does. Right, but `tuple` could then be an alias for the more general version. I...

> Even better if it supported equivalent trees of products and sums. > > ```haskell > Iso' (Int, (Bool, Char)) (Bool, (Int, Char)) > Iso' (Either Int (Either Bool Char))...

> I would like a function that navigates down probably to a newtype layer, requiring a conversion or coercion for those. I suppose the general principle of “don’t look into...

I implemented this feature a while ago (it might be on a branch? I can't remember), but never merged it because of how brittle I thought it was. Since the...

Yes, unfortunately this is known to not work. In general, type parameters that have nominal roles are not supported well. `field'` is a possible workaround. I'm now thinking it would...

Hm, I'll have a go at this tomorrow!

That seems like another rather heavy dependency. I wonder if it will pay its way

That is a good point! Need to think more about this

There might be some subtleties I'm missing, but I think we already a have a similar lens: https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens/src/Data/Generics/Product/Fields.hs#L112-L124 with the instance defined as https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens/src/Data/Generics/Product/Fields.hs#L167-L168 https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens-core/src/Data/Generics/Product/Internal/Fields.hs#L44-L50 This uses https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens-core/src/Data/Generics/Internal/Families/Changing.hs#L133-L137 This machinery...