Keenan Brock comments

Results 507 comments of


                                            Keenan Brock

[WIP] Don't include all types in Vm children

update: - fixed miq_template (mimic vm logic using `

[WIP] Don't include all types in Vm children

@Fryguy yea. I thought it was a tangent, pulled it out and the tests started failing. This change freaks out when you create a vm of `type="Vm"`. Think it was...

[WIP] Don't include all types in Vm children

@Fryguy ok, for a `Vm`, we stated that it doesn't need STI, so it does not set the `type`.

[WIP] Don't include all types in Vm children

Well, a query on `VmOrTemplate` will not tack on anything `type` or `template` related, so it will work. But if your test creates a `Vm` or other, then it will...

Set model validation lengths based upon react form maxLength

update: - fix syntax error update: - no longer require vm#description - rubocop spaces

Set model validation lengths based upon react form maxLength

update: - authentication no longer requires `name`

Set model validation lengths based upon react form maxLength

update: - Rebase - Remove `Authentication#name` presence check - `Zone#name`, `description` length from 50 to 128 update: - Fix error MiqAlert#name (mistyped to notes)

Set model validation lengths based upon react form maxLength

update: - fix merge conflict with hash serialization in `Zone`.

Set model validation lengths based upon react form maxLength

update: - rebased - removed vm limits - were via app/javascript/components/vm-common-rename-form/vm-common-rename-form.schema.js

[WIP] Add notes running vmware simulator

Had tried to default the historical intervals via https://github.com/vmware/govmomi/pull/3191 but wasn't able to get that working.