kawaemon comments

Results 5 comments of


                                            kawaemon

Allow GenericType to accept QualifiedType

@aryx ~~Looks like current CI doesn't run against pull requests. This file is written about 2 years ago, so this is not recent change. It's not running on other PRs...

Allow GenericType to accept QualifiedType

I think adding "pull_request" event here will fix this problem anyway. https://github.com/tree-sitter/tree-sitter-go/blob/13418148805c8cb50abbdfae779a59bde8fec901/.github/workflows/ci.yml#L2-L5

refine() function gets called even when parser already failed within translate()/refine()/regex()

It seems like refinement functions (such as `.regex()` or `.min()` or things like that) throws non-fatal issue so that parsing process will *continue*. To stop parsing you must mark them...

refine() function gets called even when parser already failed within translate()/refine()/regex()

> The real issue is when you do something like refine ->transform-> refine, it ends up completely violating the types Yes, I agree with that. I think the source of...

refine() function gets called even when parser already failed within translate()/refine()/regex()

> Note that this bug can also occur when the initial failure occurs in a refine, not just transform. (See my second example in the original post.) Ah I see....