tree-sitter-go icon indicating copy to clipboard operation
tree-sitter-go copied to clipboard

Published 20 hours ago • verified publisher icon tree-sitter

Allow GenericType to accept QualifiedType

Open kawaemon opened this issue 2 years ago • 1 comments

Current parser does not accept this code since GenericType does not accept QualifiedType:

func g2(a foo.bar[int]) {}

This PR fixes this behaviour.

Checklist:

  • [ ] All tests pass in CI.
  • [x] There are sufficient tests for the new fix/feature.
  • [x] Grammar rules have not been renamed unless absolutely necessary.
  • [x] The conflicts section hasn't grown too much.
  • [x] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c). 1257 -> 1269

kawaemon avatar Oct 14 '22 03:10 kawaemon

@dcreager @maxbrunsfeld something changed recently regarding CI? There's no CI check jobs running anymore ...

aryx avatar Oct 14 '22 07:10 aryx

@aryx ~~Looks like current CI doesn't run against pull requests. This file is written about 2 years ago, so this is not recent change. It's not running on other PRs as well.~~ Never mind, it was running until this april. From this May it stopped to run on PRs. It is weird indeed. Maybe GitHub changed the event specs?

kawaemon avatar Oct 19 '22 09:10 kawaemon

I think adding "pull_request" event here will fix this problem anyway. https://github.com/tree-sitter/tree-sitter-go/blob/13418148805c8cb50abbdfae779a59bde8fec901/.github/workflows/ci.yml#L2-L5

kawaemon avatar Oct 19 '22 09:10 kawaemon

@dcreager @maxbrunsfeld any idea why CI does not kick in anymore for those PRs? This seriously limit our ability to merge external PRs.

aryx avatar Oct 19 '22 10:10 aryx

I need this fix in semgrep, so I'll merge, but someone need to figure out why the CI checks do not run here anymore.

aryx avatar Oct 20 '22 07:10 aryx