Kacper Michajłow

Results 586 comments of Kacper Michajłow

All logging should go through a callback and use mp_log to print them.

> I had hoped to be able to avoid introducing a C api for logging right now due to unresolved questions about thread safety but I can provide one with...

> That's good enough then. The thread safety concerns I was mentioning are more like "do I want to allow _modifying_ the logger concurrently", for now I will restrict setting...

> Speaking of "everything being ready", I am wondering whether `textsub` is the appropriate name for the new demuxer. I initially named it that because it just passed through text...

> > Convention is to name demxu_, so sbr would not be accurate here. textsub is indeed bit vague, but I guess it tells what it actually does. But if...

show stats for both cases (shift+i)

I'm mixed about it, the size gain is not that big compared to whole mpv binary. Would be better if it were compiler option and not manually changing system libs...

Use #12566 instead

> Any progress on #12566? Looks like it's still on-ice Not on my end. I consider this patch finished and ready to go, but it is a controversial change and...

I prefer not to inject custom linker flags if possible. If this can somehow be integrated as a Meson option, we can consider it. However, for now, the benefit of...