mpv-player
ci/win32: use hybrid crt
VCRuntime is still statically linked, but now UCRT is dynamically linked, this approach is officially used by Windows App SDK.
ref: https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/HybridCRT.md
Read this before you submit this pull request: https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md
Reading this link and following the rules will get your pull request reviewed and merged faster. Nobody wants lazy pull requests.
Download the artifacts for this pull request:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm mixed about it, the size gain is not that big compared to whole mpv binary. Would be better if it were compiler option and not manually changing system libs linking.
The main point of it for me is to allow minject to work, which fixes cache deallocation performance issues on systems where SegmentHeap is not available.
Any progress on #12566? Looks like it's still on-ice
Not on my end. I consider this patch finished and ready to go, but it is a controversial change and likely won't be approved by others.
I prefer not to inject custom linker flags if possible. If this can somehow be integrated as a Meson option, we can consider it. However, for now, the benefit of linking in 'hybrid' mode is not significant for mpv. Feel free to build it that way yourself. We can reconsider if there are real use cases where this approach provides a clear advantage.