Karl
Karl
@slavapestov > I would simply punt on the issue. Feature guards are only intended to solve a limited set of problems with staging in toolchain/stdlib/SDK changes and we can't really...
> we probably want to ban @objc protocols from being nested Why? I mean, there is an issue that we don't namespace generated Obj-C names, but that is equally a...
@slavapestov OK I've added: - Refinements for the diagnostic - Tests for PrintAsObjC (including a test for a nested classes with a custom Obj-C name, which is something I think...
@slavapestov Implemented the change you suggested. Could you trigger CI please?
Test failure is due to actor availability. Doesn't happen locally when I run the tests on Sonoma. I guess it happens because CI is using an ancient version of macOS?...
@slavapestov Oops. But yeah, the macOS filesystem seems to be case-insensitive by default, so that didn't happen locally. At least that should be the last thing, since the macOS test...
Hmm it seems I need to use the substitution `%FileCheck` for FileCheck. For some reason that also wasn't necessary on macOS.
Thanks @slavapestov! And thanks for your guidance along the way! Yeah I'll cherry-pick this to the 5.10 branch :)
@rjmccall You are listed as the code-owner for IRGen. Could you take a look?
ping @rjmccall If you can't take a look yourself, could you please suggest somebody to review?