swift icon indicating copy to clipboard operation
swift copied to clipboard

Enable IRGen/protocol_metadata test on Apple Silicon

Open karwa opened this issue 1 year ago • 1 comments

This requirement seems to be too restrictive. The test works for me as-is on an M2 Max (removing the REQUIRES line, of course).

I assume the intention is to limit this to 64-bit architectures, and I think PTRSIZE=64 is the right way to do that?

karwa avatar Jun 09 '23 14:06 karwa

@rjmccall You are listed as the code-owner for IRGen. Could you take a look?

karwa avatar Jun 09 '23 15:06 karwa

ping @rjmccall

If you can't take a look yourself, could you please suggest somebody to review?

karwa avatar Jun 14 '23 11:06 karwa

This looks reasonable to me.

rjmccall avatar Jun 16 '23 19:06 rjmccall

@swift-ci Please test

rjmccall avatar Jun 16 '23 19:06 rjmccall