Karl

Results 111 comments of Karl

Wouldn't it be better to use `canImport(Darwin)`? Especially since a lot of these are literally guarding imports of the `Darwin` module and uses of symbols exported by it...

> `#if canImport()` has a namespacing issue; nothing particular prevents a Linux distribution from having a module named Darwin. We've avoided using that approach for that reason. It’s only an...

The ed2k issue seems to come from U+007C (vertical bar) being listed as a [forbidden host code-point](https://url.spec.whatwg.org/#forbidden-host-code-point). Personally I think it would be very low-risk to allow that character in...

I suspect they are inherited from RFC-2396: > Other characters are excluded because gateways and other transport > agents are known to sometimes modify such characters, or they are >...

From reading those previous discussions: `^` #458 seems to indicate that WebKit used to allow it. If I'm reading the [Gecko bug report](https://bugzilla.mozilla.org/show_bug.cgi?id=1548306) correctly, their implementation of origins included a...

To illustrate using JSDOM: ```javascript const urlRecord = parseURL("data:space #hello"); const serialized = serializeURL(urlRecord, /* excludeFragment: */ true); const reparsed = parseURL(serialized); const serializedAgain = serializeURL(reparsed, /* excludeFragment: */ true);...

I don't see any discussion last time about escaping trailing spaces. I suggested escaping _all_ spaces, but that was considered likely incompatible with the web. I think it should be...

> I'd prefer to just escape only the last trailing space. It's simpler and the algorithm would be faster. So I don't see any advantage in escaping all the trailing...

Right. The question is only about multiple trailing unescaped spaces. If the source only contains a single trailing space to begin with, the result would be the same. | |...

> > We always trim trailing spaces from opaque paths. Technically a breaking change, but overall it's better at ensuring everything stays consistent. > > This doesn't seem a popular...