Karthick Ariyaratnam

Results 7 comments of Karthick Ariyaratnam

@zuiderkwast, I have raised the PR for the above, please review. Thanks.

Thanks @PingXie @McFacePunch for the comments. Please see the latest commit. I have no idea why that test-sanitizer fails.

> I think we need some tests. The defaults can be tested in the existing test for the compat config. Custom value may need a new test case. Sure, I...

I didn’t remove the legacy endianconvTest from _serverTest_ (see commit https://github.com/valkey-io/valkey/pull/458/commits/1c59ca7036977e06ad80de71cc501ea968071dc9 ) since it gives conflict which I couldn’t resolve anyway. I thought of doing it in a subsequent PR....

@madolson could you please review and merge the above, thanks.

Same as this https://github.com/valkey-io/valkey/pull/458#issuecomment-2103744784, I didn't remove legacy zmalloc_test due to the conflict. And, I will raise a follow-up PR to remove them together. @madolson In the meantime, could you...

Please refer the PR https://github.com/valkey-io/valkey/pull/493.