valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Migrate zmalloc unit tests to new test framework

Open karthyuom opened this issue 9 months ago • 1 comments

This PR migrates all tests related to zmalloc into new test framework as part of the parent issue https://github.com/valkey-io/valkey/issues/428.

karthyuom avatar May 07 '24 22:05 karthyuom

Codecov Report

Attention: Patch coverage is 45.00000% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 69.80%. Comparing base (ba9dd7b) to head (41a8e96). Report is 22 commits behind head on unstable.

:exclamation: Current head 41a8e96 differs from pull request most recent head 9860bd0. Consider uploading reports for the commit 9860bd0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #459      +/-   ##
============================================
+ Coverage     68.95%   69.80%   +0.84%     
============================================
  Files           109      109              
  Lines         61793    61801       +8     
============================================
+ Hits          42611    43138     +527     
+ Misses        19182    18663     -519     
Files Coverage Δ
src/anet.c 70.41% <100.00%> (ø)
src/aof.c 80.85% <ø> (+0.05%) :arrow_up:
src/asciilogo.h 100.00% <ø> (ø)
src/cluster_legacy.c 86.14% <100.00%> (+2.94%) :arrow_up:
src/crccombine.c 100.00% <ø> (ø)
src/eval.c 55.45% <ø> (ø)
src/functions.c 95.62% <ø> (ø)
src/kvstore.c 96.65% <ø> (+0.25%) :arrow_up:
src/latency.c 81.49% <ø> (+0.25%) :arrow_up:
src/listpack.c 90.05% <ø> (ø)
... and 22 more

... and 13 files with indirect coverage changes

codecov[bot] avatar May 07 '24 22:05 codecov[bot]

Same as this https://github.com/valkey-io/valkey/pull/458#issuecomment-2103744784, I didn't remove legacy zmalloc_test due to the conflict. And, I will raise a follow-up PR to remove them together.

@madolson In the meantime, could you please review and merge this PR, thanks.

karthyuom avatar May 11 '24 18:05 karthyuom

Please refer the PR https://github.com/valkey-io/valkey/pull/493.

karthyuom avatar May 13 '24 17:05 karthyuom