Karteek

> @karteekmurthys Kartheek, would you squash all commits and rebase onto latest? Done.

@Yuhta request you to take a look at this PR.

@mbasmanova Hi Masha..if you have time, would you please help in review and merging of this PR?

@mbasmanova I have addressed your previous comments. Request you to do another parse.

@Yuhta please review this. I guess it is ready for merge.

@kgpai would you please review these changes?

Not able to reproduce the test failure on the docker image: ``` [ RUN ] ComparisonsTest.betweenDecimal ../../velox/functions/prestosql/tests/ComparisonsTest.cpp:302: Failure Expected equality of these values: actual->valueAt(i) Which is: true expectedResult[i] Which is:...

@kagamiori just following up on this. Lmk if you need any help.

> / SignatureBinder::tryResolveType(arg, {}) converts a TypeSignature of "short_decimal( > // a_precision, a_scale)" into a TypePtr of ScalarType. ~~This is correct because DecimalType is a ScalarType (inherits). See: https://github.com/facebookincubator/velox/blob/main/velox/type/Type.h#L621~~ ~~Here,...

> for (const auto& arg : functionSignature->argumentTypes()) { > // SignatureBinder::tryResolveType(arg, {}) converts a TypeSignature of "short_decimal( > // a_precision, a_scale)" into a TypePtr of ScalarType. > if (auto resolvedType...