velox Add Decimal multiplication function

Add Decimal multiplication function

Open karteekmurthys opened this issue 2 years ago • 11 comments

Jul 20 '22 04:07 karteekmurthys

@karteekmurthys Kartheek, would you squash all commits and rebase onto latest?

Jul 20 '22 04:07 mbasmanova

@karteekmurthys Kartheek, would you squash all commits and rebase onto latest?

Done.

Jul 20 '22 05:07 karteekmurthys

@karteekmurthys can you rebase with main? subtraction is merged.

Aug 16 '22 19:08 majetideepak

@karteekmurthys can you rebase with main branch to fix the build failure?

Aug 18 '22 11:08 majetideepak

@Yuhta request you to take a look at this PR.

Aug 19 '22 03:08 karteekmurthys

@mbasmanova Hi Masha..if you have time, would you please help in review and merging of this PR?

Aug 23 '22 02:08 karteekmurthys

Name	Link
Latest commit	e94b825e128ba7fde6204966b4a4f1945fc12890
Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/630d8dc339d061000891c9ed

Aug 23 '22 03:08 netlify[bot]

@mbasmanova I have addressed your previous comments. Request you to do another parse.

Aug 25 '22 16:08 karteekmurthys

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Aug 25 '22 23:08 facebook-github-bot

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Aug 26 '22 17:08 facebook-github-bot

@Yuhta please review this. I guess it is ready for merge.

Aug 30 '22 16:08 karteekmurthys

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sep 01 '22 14:09 facebook-github-bot