Karl Isenberg

Results 288 comments of Karl Isenberg

Gonna wait to merge this until @sdowell adds support for http access to git. That way we won't pollute the CACertSecretRef test with needing to use NoSSLVerify (which has its...

This PR is blocked on https://github.com/GoogleContainerTools/kpt-config-sync/pull/260 to make the Syncing condition consistently expose errors.

Looks like `Go / Test Linux` failed due to lacking permissions to pull from gcr.io/kustomize-functions/e2econtainersimplegenerator, gcr.io/kustomize-functions/e2econtainerconfig, and gcr.io/kustomize-functions/e2econtainerenvgenerator

Those container images do not seem to exist in GCR.

Looks like it might be due to https://github.com/docker/buildx/issues/1613 which can be mitigated by setting `BUILDKIT_NO_CLIENT_TOKEN=true` to disable client-side tokens (https://github.com/moby/buildkit/blob/v0.12.5/session/auth/authprovider/authprovider.go#L205), but I'm not 100% sure what the implications of that...

It doesn't pass when re-run. It doesn't pass locally. The whole repo is private now for some reason. It looks like the tests are using `assert` instead of `require`, so...

Alright, so the real error is from docker build because it doesn't like my new go.work module, which is specific to this PR: ``` === RUN TestFnContainerGenerator fnplugin_test.go:550: Error Trace:...

Figured it out. It's because `/.dockerignore` includes `site`, and the `e2econtainersimplegenerator` image is being built from the root of the repo directly, instead of the `cmd/config/internal/commands/e2e/e2econtainersimplegenerator` directory where the Dockerfile...

Looks like I'm gonna have to do this for all the modules to really fix the supply chain issues and pin to versions with checksums. But I got lint/build/test happy...

Using the same tools.go for all modules means that all the Dockerfiles need to be built from the repo root and copy all repo files into the docker context, which...