kpt-config-sync icon indicating copy to clipboard operation
kpt-config-sync copied to clipboard

[WIP] Add test for GIT_SSL_CAINFO env var removal

Open karlkfi opened this issue 2 years ago • 4 comments

This confirms that the new SSA used to update the reconciler Deployment correctly deletes the GIT_SSL_CAINFO env var (as long as no one else has modified it).

karlkfi avatar Nov 22 '22 23:11 karlkfi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi by writing /assign @karlkfi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Nov 22 '22 23:11 google-oss-prow[bot]

Gonna wait to merge this until @sdowell adds support for http access to git. That way we won't pollute the CACertSecretRef test with needing to use NoSSLVerify (which has its own test).

karlkfi avatar Nov 22 '22 23:11 karlkfi

@karlkfi This should add support for HTTP, although I'm still not sure whether it's needed https://github.com/GoogleContainerTools/kpt-config-sync/pull/316

sdowell avatar Nov 23 '22 00:11 sdowell

curious if this is still WIP or if it's even relevant. If it is consider closing the PR and keeping the private branch or converting to draft.

mikebz avatar Apr 17 '24 20:04 mikebz