Karl Isenberg

Results 288 comments of Karl Isenberg

@koba1t I've rebased this and changed it to use the same type of go.mod tool version pinning as hack/go.mod, but separate to serve as an example of how to pin...

I'm dealing with a bit of security theater here. I've got a scanner and policy that wants not just a pinned version but also some kind of checksum to confirm...

My first draft of this PR used the image sha and you told me not to. Thats why I switched to using go.mod. Would you prefer the image sha instead?

Replaced by https://github.com/kubernetes-sigs/kustomize/pull/5691

/hold for manual testing on autopilot.

While this might fix the bug for these tests, I think the SkipAutopilotCluster feature itserlf might be broken, causing this test to be run when it should be skipped.

This alone does not fix the issue. The namespaces never become available in test setup: ``` wait.go:122: failed after 6m0s to wait for namespace "frontend" to be ready wait.go:123: ERROR:...

/hold I need to think about this carefully and I don't really have time today. I think there's some problems with deletion ordering that might crop up in this situation....

After digging into this a bit more my concern is this: Removing the finalizer on the RepoSync when its parent Namespace is being deleted DOES solve the case where deletion...