karel-m

When talking about `xsalsa20` it may be also a good idea to consider `xchacha20` + `xchacha20poly1305` (which are supported e.g. by libsodium)

What about adding `/WX` (= treat all warnings as error)?

> well i suppose in the case of crc32_finish it's clear that the result len will be 4 bytes, so there's no need to pass a pointer-to where the size...

I do support this idea; however, this is going to break a lot of things. Basically nearly all SW using libtomcrypt. IMO this PR should be labeled `LTCv2.0` and the...

Just for record: standardisation of SM4 seems to got stuck https://tools.ietf.org/html/draft-ribose-cfrg-sm4-10

If you agree with the proposed split, which I assume you do, I (or any other volunteer) have to update doc and tests.

I do not have strong opinion on this. But I slightly lean towards leaving the cast to the calling code as by casting in these macros we may hide some...

In my perl module test suite I have these (the password is: secret) * https://github.com/DCIT/perl-CryptX/blob/master/t/data/dsa-seed.pem * https://github.com/DCIT/perl-CryptX/blob/master/t/data/ec-seed.pem * https://github.com/DCIT/perl-CryptX/blob/master/t/data/rsa-seed.pem Do we want to support them?

I see these warnings ``` $ make CFLAGS="-O2 -DUSE_LTM -DLTM_DESC -I../libtommath -Wall" -f makefile.unix cc -Isrc/headers -Itests -DLTC_SOURCE -O2 -DUSE_LTM -DLTM_DESC -I../libtommath -Wall -c src/pk/ecc/ecc_import_openssl.c -o src/pk/ecc/ecc_import_openssl.o src/pk/ecc/ecc_import_openssl.c: In function...

If we want to support even more ciphers here is how you can generate more test vectors via openssl ``` openssl genpkey -algorithm rsa -out rsa_priv.pem openssl pkey -in rsa_priv.pem...