karel-m

Deterministic ECDSA - RFC6979

11

It would be nice to support deterministic ecc signatures - see https://tools.ietf.org/html/rfc6979 It is related only to `ecc_sign_hash_ex` as the verification works as usual. It can be done without any...

An attempt to fix #449 (ECDSA forcing DER/ASN.1)

3

This PR is incomplete (as I am not sure if it is the proper fix). Cc: @sjaeckel @rmw42 TODO: - [ ] update doc - [ ] add a test...

Wycheproof failing ECC tests

2

Let's have a valid signature like: 0x30,0x45,0x02,0x20,0x2b,0xa3,0xa8,0xbe,0x6b,0x94,0xd5,0xec,0x80,0xa6,0xd9,0xd1,0x19,0x0a, 0x43,0x6e,0xff,0xe5,0x0d,0x85,0xa1,0xee,0xe8,0x59,0xb8,0xcc,0x6a,0xf9,0xbd,0x5c,0x2e,0x18, 0x02,0x21,0x00,0xb3,0x29,0xf4,0x79,0xa2,0xbb,0xd0,0xa5,0xc3,0x84,0xee,0x14,0x93,0xb1,0xf5, 0x18,0x6a,0x87,0x13,0x9c,0xac,0x5d,0xf4,0x08,0x7c,0x13,0x4b,0x49,0x15,0x68,0x47,0xdb, Now let's patch the first `0x30` to `0x31` like: 0x31,0x45,0x02,0x20,0x2b,0xa3,0xa8,0xbe,0x6b,0x94,0xd5,0xec,0x80,0xa6,0xd9,0xd1,0x19,0x0a, 0x43,0x6e,0xff,0xe5,0x0d,0x85,0xa1,0xee,0xe8,0x59,0xb8,0xcc,0x6a,0xf9,0xbd,0x5c,0x2e,0x18, 0x02,0x21,0x00,0xb3,0x29,0xf4,0x79,0xa2,0xbb,0xd0,0xa5,0xc3,0x84,0xee,0x14,0x93,0xb1,0xf5, 0x18,0x6a,0x87,0x13,0x9c,0xac,0x5d,0xf4,0x08,0x7c,0x13,0x4b,0x49,0x15,0x68,0x47,0xdb, We still verify the patched signature whereas...

This si a note for myself to analyze what's wrong in the crash described here: https://bugzilla.redhat.com/show_bug.cgi?id=1850650

ecc_sign_hash_ex + ecc_verify_hash_ex forces linking DER/ASN.1 code

2

this is an issue related to the discussion in #438 > The current all-in-one ecc_sign_hash_ex and ecc_verify_hash_ex forces anyone using ECDSA to link the whole ASN.1 stuff to their binary...

Reconsider the default mode for LTC_ARGCHK

4

Currently by default the LTC_ARGCK calls `abort()` when the check in question fails. Isn't it too strict to literally die (core-dump) when you for example "only" pass an IV of...

While hacking on https://github.com/DCIT/perl-CryptX/pull/59 I have found out that our current implementation of `ed25519_verify` falsely validates/verifies the following signatures which should be rejected: ```json { "tcId" : 63, "comment" :...

Some MSVC warnings (just FYI)

3

Visual Studio 2008 (32bit build): ``` 1>padding_pad.c 1>d:\git\libtomcrypt\src\misc\padding\padding_pad.c(126) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data 1>d:\git\libtomcrypt\src\misc\padding\padding_pad.c(131) : warning C4244: '=' :...

fix or drop LTC_MECC_FP

1

In the branch `pr/fix-LTC_MECC_FP` I have tried (unsuccessfully) to fix `LTC_MECC_FP` support. The fix does not work but before I invest more time into it I want to ask whether...

UBSAN & load/store of misaligned address

6

UBSAN (UndefinedBehaviorSanitizer) reports the following issues on current `release/1.18.0` (all related to `LTC_FAST_TYPE`): ``` src/modes/ctr/ctr_encrypt.c:91:60: runtime error: load of misaligned address 0x00000182dadc for type 'LTC_FAST_TYPE' (aka 'unsigned long long'), which...