libtomcrypt icon indicating copy to clipboard operation
libtomcrypt copied to clipboard

[WIP/RFC] Remove prng registry

Open sjaeckel opened this issue 5 years ago • 5 comments

The first step into the direction of a registry-free LibTomCrypt

  • [ ] documentation is added or updated
  • [x] tests are added or updated

sjaeckel avatar Oct 20 '19 11:10 sjaeckel

I do support this idea; however, this is going to break a lot of things. Basically nearly all SW using libtomcrypt.

IMO this PR should be labeled LTCv2.0 and the timing of merging into develop should be carefully considered.

I'll hopefully find some time for deeper review.

karel-m avatar Oct 20 '19 17:10 karel-m

I do support this idea; however, this is going to break a lot of things. Basically nearly all SW using libtomcrypt.

yep, one has to break stuff sometimes to be able to advance

IMO this PR should be labeled LTCv2.0 and the timing of merging into develop should be carefully considered.

yes it will be 2.0 and IMO the branch is called develop for a reason and contains the next version, no matter how hard it will break previous versions, so I think it should be merged as soon as it's ready.

I'll hopefully find some time for deeper review.

The most important part of this PR is the decision if desc can be put into state or whether we should do it somehow differently!?

The rest of the PR is going through the sources and adapting to the new API.

sjaeckel avatar Oct 21 '19 09:10 sjaeckel