karel-m

I think @sjaeckel 's patch https://github.com/libtom/libtomcrypt/commit/d20fdcc76d6b78059af4b847b428bd34972883ce is slightly better

No problem, it can wait a month (or two).

To my surprise even pretty old MS compilers are able to handle `size_t`.

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008...

No, makefile.msvc is not what I want. The other thing is that it is not sufficient to just save the original `.vcproj` as `.vcxproj`. Somebody has also update `helper.pl` so...

I will support this PR only when it keeps support for both cases: * `libtomcrypt_VS2008.sln` + `libtomcrypt_VS2008.vcproj` * `libtomcrypt_VS2015.sln` + `libtomcrypt_VS2015.vcxproj` (not sure about having .vcxproj.filters in git) But again,...

**Update:** with `-DLTC_NO_FAST` no UBSAN issues in `release/1.18.0`

I suggest just keeping separate NN_memory, NN_test, NN_keystream and perhaps NN_done like: ``` Old style This PR Karel's suggestion ================================= ======================================= ==================================== rabbit/rabbit.c rabbit/rabbit.c rabbit/rabbit_common.h rabbit/rabbit_setup.c rabbit/rabbit_setiv.c rabbit/rabbit_crypt.c rabbit/rabbit_done.c +rabbit/rabbit_done.c...

plus perhaps also get rid of `sober128tab.c`

I see your point but to me this is "over-consistent" for no (or very little) gain. Anyway, I am strongly against introducing new headers - `_common.h`. I suggest either to...