libtomcrypt icon indicating copy to clipboard operation
libtomcrypt copied to clipboard

Published 20 hours ago • verified publisher icon libtom

Visualstudio solution

Open FredeJ opened this issue 5 years ago • 7 comments

Migrate the solution file to Visual Studio 15.

The goal of this is to allow libtomcrypt to be made available through vcpkg (https://github.com/microsoft/vcpkg/)

FredeJ avatar Oct 25 '19 13:10 FredeJ

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility.

karel-m avatar Oct 25 '19 15:10 karel-m

@FredeJ is it an option to use the makefile.msvc for your purpose?

sjaeckel avatar Oct 25 '19 15:10 sjaeckel

No, makefile.msvc is not what I want.

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

karel-m avatar Oct 25 '19 16:10 karel-m

No, makefile.msvc is not what I want.

I asked @FredeJ ;-)

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

Right, I thought that was done, but apparently it wasn't.

sjaeckel avatar Oct 25 '19 16:10 sjaeckel

I will support this PR only when it keeps support for both cases:

  • libtomcrypt_VS2008.sln + libtomcrypt_VS2008.vcproj
  • libtomcrypt_VS2015.sln + libtomcrypt_VS2015.vcxproj (not sure about having .vcxproj.filters in git)

But again, somebody has to fix helper.pl so that it is able to update .vcxproj.

karel-m avatar Oct 25 '19 16:10 karel-m

@sjaeckel makefile.msvc seems to be able to get me basically 95% there. I was not aware of nmake at all but was just using msbuild, which failed with the older project and solution files.

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

FredeJ avatar Oct 28 '19 13:10 FredeJ

@sjaeckel makefile.msvc seems to be able to get me basically 95% there

cool :)

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

uhm, pass in some CFLAGS and change the libname for the debug build? something like nmake -f makefile.msvc CFLAGS="-MTd" LIBMAIN_S="tomcrypt-debug.lib"

I don't run windows, so I can't tell if it's exactly like that, but that should give you a direction

sjaeckel avatar Oct 28 '19 13:10 sjaeckel