Andreas Stenius

Results 274 comments of Andreas Stenius

> Hey @kaos, could you take another look? Thanks ops, this must've fallen prey to my GH notifications cleanup. (had many hundreds of unread notifications, so in an attempt to...

> Does this influence process execution caching? Very good and relevant question. I hope I'm not wrong here, but I think the answer is no. If you run `pants test...

we should have a dependabot thing for this......... ;)

Have we deprecated the use of `PANTS_SHA` now then? As that will stop to work once we remove `src/python/pants/VERSION`. https://github.com/pantsbuild/scie-pants/blob/2cd4278eb8bf773b398b88cdf6ef64fe5a4843bf/tools/src/scie_pants/pants_version.py#L153-L155

> > Have we deprecated the use of `PANTS_SHA` now then? > > As that will stop to work once we remove `src/python/pants/VERSION`. > > https://github.com/pantsbuild/scie-pants/blob/2cd4278eb8bf773b398b88cdf6ef64fe5a4843bf/tools/src/scie_pants/pants_version.py#L153-L155 > > Yes, IIRC...

> Found it: https://github.com/pantsbuild/scie-pants/blob/main/CHANGES.md#L43 Ah yea, me also: https://github.com/pantsbuild/scie-pants/pull/351/files#diff-d975bf659606195d2165918f93e1cf680ef68ea3c9cab994f033705fea8238b2 :)

> > Have we deprecated the use of `PANTS_SHA` now then? > > As that will stop to work once we remove `src/python/pants/VERSION`. > > https://github.com/pantsbuild/scie-pants/blob/2cd4278eb8bf773b398b88cdf6ef64fe5a4843bf/tools/src/scie_pants/pants_version.py#L153-L155 > > Yes, IIRC...

> Getting closer! > > Good catch re the `scie-pants` checks. Even if we do land the scie-pants change, landing this might be a breaking change, as anyone using `PANTS_SOURCE`...

> dynamic or static linting about how the "highest risk" fields like warn_or_error and deprecated_version are used, to check that they're always referring to .dev0 releases? This makes sense to...

> @kaos , the way the PR is currently one does have to refer to the configured backends still in `backend_packages`. Yep, and I like that. 👍🏽 > What do...