Andreas Stenius

Results 274 comments of Andreas Stenius

> There is more, I placed the `--output` option right after buildx and it failed exactly as we have seen it before, so Process is placing some of those options...

> But entering that sandbox and running the command works: @avilaton, Does it also work if you use the `__run.sh` script? That script more closely resembles the actual command run...

Perhaps include a paragraph in the docs somewhere how this is done?

> How do I make sure the tests only run for python>=3.8? Look at how these have been applied: https://github.com/pantsbuild/pants/blob/main/src/python/pants/testutil/python_interpreter_selection.py

Would be great with a few more lines of docs, describing at least briefly how to enable and use this backend :) (I think that there are two backends to...

> Thanks for this @grihabor, exciting to have a new useful backend like this. > > I do have one comment which may not be immediately actionable: I wonder if...

`yamllint` was added in https://github.com/pantsbuild/pants/pull/17821

to be clear, I'm fine keeping this as-is for now as well.. just good to be aware of the alternative to consider going forward :)

> Ok, so this PR grew a bit in scope trying to attempt [#20934 (comment)](https://github.com/pantsbuild/pants/pull/20934#discussion_r1606318444) . > > In short, I've added support to: > > * Unparametrize address when...

Excellent find! I'd just like to point out that this is a address issue, the actual resolve is correct: ``` ❯ pants peek --exclude-defaults "helloworld/translator/translator.py" [ { "address": "helloworld/translator/translator.py:lib@resolve=python-default", "target_type":...