Andreas Stenius

This is a good find, and thanks for the write up, Huon. I think `all` serves a good purpose (consider the case of optionally enable/disable backends, you couldn't have defaults...

> > I think all serves a good purpose (consider the case of optionally enable/disable backends, you couldn't have defaults in BUILD files for any targets that are disabled, making...

Nice work. I agree this deserves addressing. I would prefer however if we could make it happen less intrusive. That is, not put the heavy lifting on the plugins and...

> Thank you for your comments! > > > Some ideas: it is during target generation/creation we have the perfect opportunity to provide additional target meta data. Pants could leverage...

> Cool, I'm glad you like the idea! > > > Targets are created in two phases: phase one creates TargetAdaptors during BUILD file parsing and are collected into AddressFamilys...

@grihabor Hi, no worries, there's quite a few moving parts to get to grips with here. The file a target corresponds to is tracked in `description_of_origin`, so that information is...

Ah yea, re-reading your comment again, I see that I mostly agree with your suggestion about what information you've included in the suggested blocks field, only to not have it...

> [...] But this is weird, because filename is usually provided by `SingleSourceField` just noting, that I don't find this weird at all, as the source field doesn't necessarily always...

> I've added a test for fine grained --changed-since with line numbers here [4115588](https://github.com/pantsbuild/pants/commit/41155889f36adf333bdc90bf6164fdc238826310). I had to add a dummy plugin to declare targets that have text blocks, I'm not...

Thanks. Will take a closer look this week.