Kanit Wongsuphasawat

Results 159 comments of Kanit Wongsuphasawat

I think we should provide helper functions because it's not a realistic expectation that Vega-Lite users should know how we name the underlying data sources and signals. Plus, there is...

Just got a chance to follow up on this. The refactor in #4068 is very helpful for interacting with selection data. However, whether we (1) have a thin wrapper around...

Another question. The signal refactor definitely makes _reading_ the selection quite straightforward. However, I remember @arvind mentioned that setting the selection is still tricky. If so, should we start a...

Looking closer at selection codebase, currently the `unit` in the selection data store is generated using the [`unitName()`](https://github.com/vega/vega-lite/blob/master/src/compile/selection/selection.ts#L360) method. For faceted plots, which can contain multiple units of the same...

Note that I think the format `{Cylinders: 6}` should be reasonable as nested / crossed facet shouldn't use the same field in multiple row/column channels. Even if users do, many...

Oh, but the other tricky part is repeat like @arvind originally suspected. Basically, we populate subplot's `unit` name by appending the repeated variable name to the original unit name. So...

FWIW, this discussion/confusion makes it clear that we should try to include this in 4.0 if we have time to do so.

This should be more consistent with Vega and smaller than datalib.

See https://github.com/vega/vega-lite/pull/2080/files and https://github.com/vega/vega-lite/issues/1885

This one is a little tricky because color uses the same field as y and we haven't handled ranking when people over-encode things.