Kanit Wongsuphasawat comments

Results 159 comments of


Kanit Wongsuphasawat

support list/array for datum for text encoding

Some notes if someone wanna help fix this: Relevant type definitions are - `TextDef` https://github.com/vega/vega-lite/blob/main/src/channeldef.ts#L198, which imports Text from Vega. - `DatumDef`, which seem to not accept string array yet

Filtering out zero/null values in tooltip and sort the tooltip by field values

moving ticket to vega-tooltip repo since it's vega-tooltip specific feature.

Filtering out zero/null values in tooltip and sort the tooltip by field values

I think this reads more like the spec is filtering the field in general, rather than in tooltip?

Categorical "count" field on color doesn't work for line and area

This is probably coming from facet operator in Vega.

Blank subplots when faceting by binned field in 2D facet chart

@jonmmease I think you're analysis seems right. Happy to review a PR if you submit a fix. :)

Vega runtime crashes when `domain.unionWith` has `null`

The problem is probably with how Vega implements `unionWith`.

Please create dist folder

Customizing color mapping while using domain that comes from data only

Here is a [hack](https://vega.github.io/editor/#/url/vega-lite/N4KABGBEDGD2B2AzAlgc0gLjMSA3ZApgO6bYwIAuy8ArrDQM4DqyAJhQBakAsADLwBooceFVr0GACQJoOFUgGZ+AX2UDwUVgEMKW0jnhaAtgVKRtugLQBOAOzXurAtC2JWANm4KAjAoIAmaABWBVtEAndEaGsggCNtAA5INQ0NSCMtACcAa31ICgBPAAdTLEgi2Gp5IUgGCkzYbNKyBjRDABszYAByAEFurG7MglZuoW6AIQGwbtRhgngxmYBhae7Y9poCbuUAbQsaIwA6dq1YgnaAXWSUiEgFuFZqdCxQCDu4dthM-Q13qEKJTM8FgRmoWk66n+dxQF1YZlO50hf3ekHaBFQC3hrxR-1qBSMsVg7QAyvVGgRlsTvr9odDam0IV0+mthqNxlNBnMCAslt1VoMNlsdvsdIcTmcLtdce9lDLlGAUbdUQwOFoga98sVmpAQWCOpAarD2tioIiLskoaiAB55QE6gCONC0omQuiouFMRsIJrMtuVdwKdu1ZidLqo7uQnsNUGNpsgQblEGVkAAJAxoBwCBkzHIKEUGBgAPRFz2oLRHVBujg0WJHZCwIsZrMZUsYrSWdpugil7hHBJHbxHABWDAQhrSFi0DAIFAYtNRU5s9kczlcHi8vgCwVC4Ui0TiiVIuxlOFtWG8NSDWAUNXNnTKvUtp8g57A-ivpA-ZslD6gE2fOkz0UT8LzvX8zCfJN3kuDQ5WUIA) that works (using the experimental "signal" feature): Essentially, I override the mark stroke with a custom color scale that does my own mapping. I still keep...

Customizing color mapping while using domain that comes from data only

To support this in a natural (not hacky) way, I think we have to discuss if we distinguish between the domain for driving guides and the domain for direct mapping...