kangy-google

Results 10 comments of kangy-google

Looks like contributor-membership-checker failed, but it is not clear to me what it means

Please let me know if there is anything else I should do.

> > Please let me know if there is anything else I should do. > > Could you add the missing fields based on the `Missing Test Report`? Added.

It is not clear which check failed, can you take a look? Thanks!

Alright, tests are passing. Please take another look when you get a chance. Thanks!

I don't fully understand the semantics of default_from_api and immutable. Are they documented anywhere?

Hey, I can repro this in my test environment. We use [controller-time/testenv](https://book.kubebuilder.io/reference/envtest.html) for our test setup. We use a custom [rate limiter](https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/ratelimiter) with a constant delay. When the delay is...