magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Add `ephemeral_directories` to google_workstations_workstation_config
Release Note Template for Downstream PRs (will be copied)
workstations: add support for `ephemeral_directories` in `google_workstations_workstation_config`
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks like contributor-membership-checker failed, but it is not clear to me what it means
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 40 insertions(+)) Terraform Beta: Diff ( 3 files changed, 352 insertions(+)) TF Conversion: Diff ( 1 file changed, 95 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_workstations_workstation_config (38 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_workstations_workstation_config" "primary" {
ephemeral_directories {
gce_pd {
disk_type = # value needed
source_image = # value needed
}
}
}
Tests analytics
Total tests: 31
Passed tests: 30
Skipped tests: 0
Affected tests: 1
Click here to see the affected service packages
- workstations
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkstationsWorkstationConfig_ephemeralDirectories
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_ephemeralDirectories[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Please let me know if there is anything else I should do.
Could you add the missing fields based on the Missing Test Report?
Please let me know if there is anything else I should do.
Could you add the missing fields based on the
Missing Test Report?
Added.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 40 insertions(+)) Terraform Beta: Diff ( 3 files changed, 442 insertions(+)) TF Conversion: Diff ( 1 file changed, 95 insertions(+))
Tests analytics
Total tests: 32
Passed tests: 31
Skipped tests: 0
Affected tests: 1
Click here to see the affected service packages
- workstations
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkstationsWorkstationConfig_ephemeralDirectories_withSourceImage
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_ephemeralDirectories_withSourceImage[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 40 insertions(+)) Terraform Beta: Diff ( 3 files changed, 442 insertions(+)) TF Conversion: Diff ( 1 file changed, 95 insertions(+))
Tests analytics
Total tests: 32
Passed tests: 31
Skipped tests: 0
Affected tests: 1
Click here to see the affected service packages
- workstations
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkstationsWorkstationConfig_ephemeralDirectories_withSourceImage
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_ephemeralDirectories_withSourceImage[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Alright, tests are passing. Please take another look when you get a chance. Thanks!
I don't fully understand the semantics of default_from_api and immutable. Are they documented anywhere?
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 40 insertions(+)) Terraform Beta: Diff ( 3 files changed, 440 insertions(+)) TF Conversion: Diff ( 1 file changed, 95 insertions(+))
Tests analytics
Total tests: 32
Passed tests: 32
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- workstations
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log