Kevin Anderson

Results 405 comments of Kevin Anderson

Friendly ping @abhisheksparikh about this PR :)

Test failure is in `test_daytime.py`; not caused by this PR. See https://github.com/pvlib/pvlib-python/issues/2238

Yes I think it's time to merge this. Thanks @eccoope and @cwhanse for making this PR happen!

There is also the OSTI software record: https://www.osti.gov/biblio/1972998 It's also common to cite a github repository. For now I'd probably cite Kirsten's PVPMC presentation and, if I actually used the...

I believe the referenced method was just added in https://github.com/pvlib/pvanalytics/pull/142, and note the PVSC paper referenced in its docstring

Put another way, the problem is that we are trying to fit three states (pass, fail, N/A) into a two-state variable. > I don't think False (in pvanalytics) should be...

I think inferring whether an energy series is cumulative is unrelated enough from estimating the corresponding interval energy series that they should be implemented in separate functions. I also think...

Here's a short example of appropriate treatment of two ways cumulative energy is often reported: https://gist.github.com/kanderso-nrel/672763bb0dc8c23432a2072ba011ce9f

Here's the updated link (old one broke because of my username change): https://gist.github.com/kandersolar/672763bb0dc8c23432a2072ba011ce9f

> Since we have the soiling module in pvlib, should this be in pvlib-python? IMHO: methods of predicting soiling ratio for performance modeling purposes belong in pvlib-python and methods of...