Kamil Mysliwiec

Results 498 comments of Kamil Mysliwiec

It seems that `WsParamsFactory` retrieves `undefined` value as input arguments (`args === undefined`) and so it returns `null`. I don't have too much time atm to investigate it further though....

I've looked into this issue once again and I can see that `WsParamsFactory#exchangeKeyForValue` receives `undefined` as args because `ExternalContextCreator` passes them as a third argument, while `WsParamsFactory` only takes 2:...

@VinceOPS There might be several different reasons why this is happening. Maybe check if this line: ```typescript const module = this.getContextModuleName(instance.constructor); ``` in `ExternalContextCreator#create` gives you any reasonable output (`module`...

@uc4w6c it has introduced tons of breaking changes and regressions

Would you like to create a PR to address this issue?

Sounds great @stanimirovv!

> ask nicely tree-kill to output more legible error when no ps is available Would you like to create an issue in the `tree-kill` repo? - add ps dependency to...

Reflection doesn't give us any information about optionals/default values. We'd have to use a new script that makes use of AST to properly indicate whether something is required or not.

The plugin released in version 4.0.0 will automatically detect optional properties in your class https://docs.nestjs.com/recipes/swagger. However, it still doesn't check controller's methods signature (something to add in the future).

> I tried to invastigate it further. The problem is, that Reflect.getMetadata(constants.PARAMTYPES_METADATA, instance, method.name) returns object type for all union types (eg: string | undefined) and all object types are...