nest-cli icon indicating copy to clipboard operation
nest-cli copied to clipboard

Switching to Monorepo dry run bug

Open nik-here opened this issue 4 years ago • 6 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current behavior

Nest Cli creates the apps folder with the app from the standard mode.

Minimum reproduction code

https://github.com/nestjs/nest-cli

Steps to reproduce

  1. type in terminal: nest new my-project
  2. choose: npm
  3. type in terminal: cd my-project/
  4. type in terminal: nest g -d app my-app

Expected behavior

Nest Cli doesn't create the apps folder with the app from the standard mode, because of the dry run flag.

Package

  • [ ] I don't know. Or some 3rd-party package
  • [ ] @nestjs/common
  • [ ] @nestjs/core
  • [ ] @nestjs/microservices
  • [ ] @nestjs/platform-express
  • [ ] @nestjs/platform-fastify
  • [ ] @nestjs/platform-socket.io
  • [ ] @nestjs/platform-ws
  • [ ] @nestjs/testing
  • [ ] @nestjs/websockets
  • [X] Other (see below)

Other package

nest cli

NestJS version

8.2.6

Packages versions

{
  "name": "my-project",
  "version": "0.0.1",
  "description": "",
  "author": "",
  "private": true,
  "license": "UNLICENSED",
  "scripts": {
    "prebuild": "rimraf dist",
    "build": "nest build",
    "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
    "start": "nest start",
    "start:dev": "nest start --watch",
    "start:debug": "nest start --debug --watch",
    "start:prod": "node dist/main",
    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
    "test": "jest",
    "test:watch": "jest --watch",
    "test:cov": "jest --coverage",
    "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
    "test:e2e": "jest --config ./test/jest-e2e.json"
  },
  "dependencies": {
    "@nestjs/common": "^8.0.0",
    "@nestjs/core": "^8.0.0",
    "@nestjs/platform-express": "^8.0.0",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",
    "rxjs": "^7.2.0"
  },
  "devDependencies": {
    "@nestjs/cli": "^8.0.0",
    "@nestjs/schematics": "^8.0.0",
    "@nestjs/testing": "^8.0.0",
    "@types/express": "^4.17.13",
    "@types/jest": "27.0.2",
    "@types/node": "^16.0.0",
    "@types/supertest": "^2.0.11",
    "@typescript-eslint/eslint-plugin": "^5.0.0",
    "@typescript-eslint/parser": "^5.0.0",
    "eslint": "^8.0.1",
    "eslint-config-prettier": "^8.3.0",
    "eslint-plugin-prettier": "^4.0.0",
    "jest": "^27.2.5",
    "prettier": "^2.3.2",
    "source-map-support": "^0.5.20",
    "supertest": "^6.1.3",
    "ts-jest": "^27.0.3",
    "ts-loader": "^9.2.3",
    "ts-node": "^10.0.0",
    "tsconfig-paths": "^3.10.1",
    "typescript": "^4.3.5"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "json",
      "ts"
    ],
    "rootDir": "src",
    "testRegex": ".*\\.spec\\.ts$",
    "transform": {
      "^.+\\.(t|j)s$": "ts-jest"
    },
    "collectCoverageFrom": [
      "**/*.(t|j)s"
    ],
    "coverageDirectory": "../coverage",
    "testEnvironment": "node"
  }
}

Node.js version

v14.18.1

In which operating systems have you tested?

  • [X] macOS
  • [ ] Windows
  • [ ] Linux

Other

No response

nik-here avatar Jan 30 '22 09:01 nik-here

Nest CLI Version : 8.2.0

nik-here avatar Jan 30 '22 09:01 nik-here

This does reproduce in a docker container as well.

docker run -it node:latest sh
npm i -g @nestjs/cli
nest new my-project -p npm
cd my-project
ls # notice a `src/` and no `apps/` direcoty
nest g -d app my-app
ls # notice no `src/` and an `apps/` directory

jmcdo29 avatar Jan 30 '22 09:01 jmcdo29

Would you like to create a PR to address this issue?

kamilmysliwiec avatar Jan 30 '22 10:01 kamilmysliwiec

@kamilmysliwiec I have no time at the moment to contribute to another projects.

nik-here avatar Jan 30 '22 10:01 nik-here

@kamilmysliwiec if this issue is up for grabs I would like to work on it.

stanimirovv avatar Mar 17 '22 08:03 stanimirovv

Sounds great @stanimirovv!

kamilmysliwiec avatar Mar 17 '22 09:03 kamilmysliwiec