Kaival Parikh
Kaival Parikh
Yet to be added: - Index info operation (some segment info?) - pre/post filter (currently pre-filters by default, add option for over-selection + post-filter) - some output formatting (only basic...
Thanks @benwtrent! Added an entry now..
Saw some merge conflicts after a recent commit and resolved those..
Hi @benwtrent @vigyasharma could you help review this? Thanks!
Summary of latest changes: 1. Resolved merge conflicts 2. Moved `CHANGES.txt` entry from 9.11 -> 9.12 since the prior is now released 3. `#Scorer` is now `final` and not overrideable,...
There was a conflict in `CHANGES.txt` after a recent commit, merged from `main` and resolved that @vigyasharma I've tried to address all open comments, please let me know if something...
Thank you @vigyasharma!
@msokolov I wasn't sure about attempting to index a large amount of vector data, given that it'll take up a few GB of RAM. I've added a test for now,...
> we had unit test coverage for these classes at _all_ Yes, we have a [test class](https://github.com/apache/lucene/blob/ff6c940bcb7c6d072ac472e63ef385aa346c6172/lucene/sandbox/src/test/org/apache/lucene/sandbox/codecs/faiss/TestFaissKnnVectorsFormat.java#L37) that runs all tests in the [`BaseKnnVectorsFormatTestCase`](https://github.com/apache/lucene/blob/ff6c940bcb7c6d072ac472e63ef385aa346c6172/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java#L112) We had to [modify / disable...
Thanks @mikemccand! > Do we have any tests that check for memory leaks? I don't think we have tests today, so I opened #14875 to track it -- plus the...