Add timeout support to AbstractVectorSimilarityQuery
Description
Along similar lines of #13202, adding timeout support for AbstractVectorSimilarityQuery which performs similarity-based vector searches
While the graph search happens inside #scorer, it may go over the configured QueryTimeout and we can early terminate it to return whatever partial results are found..
One inherent benefit we have for exact search is that we return a lazy-loading iterator over all vectors, so this is inherently covered by the TimeLimitingBulkScorer (as opposed to exact search of AbstractKnnVectorQuery which manually goes over all vectors to retain the topK during #rewrite)
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
This seems sane to me.
@vigyasharma what do you think?
@kaivalnp could you update CHANGES as well?
Thanks @benwtrent! Added an entry now..
Saw some merge conflicts after a recent commit and resolved those..
Hi @benwtrent @vigyasharma could you help review this? Thanks!
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
Summary of latest changes:
- Resolved merge conflicts
- Moved
CHANGES.txtentry from 9.11 -> 9.12 since the prior is now released #Scoreris nowfinaland not overrideable, changedVectorSimilarityScorer->VectorSimilarityScorerSupplier
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!
There was a conflict in CHANGES.txt after a recent commit, merged from main and resolved that
@vigyasharma I've tried to address all open comments, please let me know if something is missing
Thank you @vigyasharma!