lucene icon indicating copy to clipboard operation
lucene copied to clipboard

Add timeout support to AbstractVectorSimilarityQuery

Open kaivalnp opened this issue 1 year ago • 9 comments

Description

Along similar lines of #13202, adding timeout support for AbstractVectorSimilarityQuery which performs similarity-based vector searches

While the graph search happens inside #scorer, it may go over the configured QueryTimeout and we can early terminate it to return whatever partial results are found..

One inherent benefit we have for exact search is that we return a lazy-loading iterator over all vectors, so this is inherently covered by the TimeLimitingBulkScorer (as opposed to exact search of AbstractKnnVectorQuery which manually goes over all vectors to retain the topK during #rewrite)

kaivalnp avatar Apr 09 '24 11:04 kaivalnp

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Apr 24 '24 00:04 github-actions[bot]

This seems sane to me.

@vigyasharma what do you think?

benwtrent avatar Apr 24 '24 19:04 benwtrent

@kaivalnp could you update CHANGES as well?

benwtrent avatar Apr 24 '24 19:04 benwtrent

Thanks @benwtrent! Added an entry now..

kaivalnp avatar Apr 24 '24 21:04 kaivalnp

Saw some merge conflicts after a recent commit and resolved those..

kaivalnp avatar May 09 '24 21:05 kaivalnp

Hi @benwtrent @vigyasharma could you help review this? Thanks!

kaivalnp avatar May 13 '24 08:05 kaivalnp

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar May 28 '24 00:05 github-actions[bot]

Summary of latest changes:

  1. Resolved merge conflicts
  2. Moved CHANGES.txt entry from 9.11 -> 9.12 since the prior is now released
  3. #Scorer is now final and not overrideable, changed VectorSimilarityScorer -> VectorSimilarityScorerSupplier

kaivalnp avatar Jun 10 '24 13:06 kaivalnp

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Jun 26 '24 00:06 github-actions[bot]

There was a conflict in CHANGES.txt after a recent commit, merged from main and resolved that @vigyasharma I've tried to address all open comments, please let me know if something is missing

kaivalnp avatar Aug 05 '24 09:08 kaivalnp

Thank you @vigyasharma!

kaivalnp avatar Aug 06 '24 05:08 kaivalnp