Kai Blumberg
Kai Blumberg
I also think it makes more sense for FOODON to take them as well as their children, ENVO:02000048 and ENVO:02000054. That way everything under the `food material` hierarchy is in...
> Move both island and ABP to be directly under ABP I totally agree and think this is an easy fix. > Review phase-axes of ABP subclasses - provide objective...
Thanks @dr-shorthair very relevant here.
I believe this could simply be fixed in FOODON by asserting `food material` under `material entity` there.
👍 to reducing reciprocal dependencies where possible and minimizing the use of subclassing non ENVO. However, I understand there might still be cases where it's useful. So I reiterate the...
> Shall I make the label and parent changes on current pull request (which should trigger a new approval process?) OR I'll make the changes asap on a new request...
Yes sorry we were conflating issues. This thread is about not subclassing NON envo: Recap: @cmungall: "Never subclass NTRs to non ENVO classes unless it's BFO/COB". @kaiiam: "Sounds reasonable as...
Lets leave this open until it goes into the docs. I've added the documentation label so we can find it later.
By the same logic, ENVO probably doesn't need to import [milk or milk component](http://purl.obolibrary.org/obo/FOODON_03420113) from FOODON at the top of the ontology. Additionally It could be confusing to non ontologists...
Thanks @cmungall, there are many of these MIXS terms across all the packages which can be make use of existing templates such as the [chemical_concentration](https://github.com/EnvironmentOntology/envo/blob/master/src/envo/modules/chemical_concentration.csv) robot templates. As I will...