Kristian Agasøster Haaga

> turns out, you cannot put docstrings before @inbounds. Nice to know :D

There's a weird test error. Not sure why this occurs. Do the docs build locally?

The doc errors are not as cryptic, but there's still a few points to fix:

Is it on purpose that this figure isn't displayed in the generated docs, @Datseris ?

> `downsample(a::MultiScaleAlgorithm, x::AbstractDataset) = Dataset(map(t -> downsample(a, t), columns(x))...) ?` Excellent. This will work generically. I'll add this to #132 straight away.

Reminder: we have two existing signature for `probabilities(x::AbstractVector, est::SymbolicPermutation)` and `probabilities(x::AbstractDataset, est::SymbolicPermutation)`. The multivariate permutation approach (ignored the multi-scale aspect for now) conflicts with the latter. We need to decide...

Yes, that is correct. Random shuffle surrogates (which only preserve the amplitude distribution of the data) or random block shuffle surrogates (preserves short-term correlations, but breaks long-term correlations) would work...

This certainly looks useful, though. Thanks for bringing the method to my attention! I'm busy with other things at the moment, but might get some time in a few weeks...

> I am wondering, whether we could provide the surrogate methods which are based on fourier transform for irregular time series by using the non-equdistant fourier transform https://github.com/tknopp/NFFT.jl. > This...

> Are there any tests, to make sure, that the surrogates we construct have the correct properties? I looked at the tests here, but they are only checking for the...