k-bar

why not just use exit or quit then?

Actually I guess it maybe seen like quit from this menu back to game... Exit to Main Menu leaves no doubts. Main Menu - idk. Still someone may think it...

Please assist me with extracted functions placement in files for this commit: https://github.com/diasurgical/devilutionX/pull/4606/commits/7b03ba60fb58408461fd64e6707ef15c3987419b I placed new functions at the end of struct / file.

Yeah, I am not happy with those names. I treat them as temporary (by means of future refactoring iterations) but still informative at the moment. As I know what function...

I found a way to use [template method](https://refactoring.guru/pl/form-template-method) pattern using (wait for it) function template ;) It provides compile time polymorphism. It can be first step, and later, when controversy...

another note: Comment on [Disolving of LiftGargoylesOrIgnoreMages aka CheckMonsterHit](https://github.com/diasurgical/devilutionX/pull/4570/commits/0d443e0fccea81318ff231fce620e5e2862c36b3) commit. `LiftGargoylesOrIgnoreMages` (previously: `CheckMonsterHit`) function was used in `TryHitMonster` (previously `MonsterMHit` and `MonsterTrapHit`), `PlrHitMonster` and `MonsterAttackMonster`. The latter one is actually...

I removed virtuals, and questionable function names, what else could I do to make this merged? At function complexity subject - I will describe in few words first commit: -...

> Let me know if you need any help with rebasing :) I was thinking about doing 1 more split, or even do all thing in this split but in...

I created split 2. I was thinking it is possible to review it while draft, but seems it is not possible :) So I converted it as ready for review.

somebody stop me just wanted to squelch some clang-tidy warnings: - misc-non-private-member-variables-in-classes - invalid case style for member