Jeffrey Yasskin

Results 212 comments of Jeffrey Yasskin

It's been discussed. The obvious solution of deleting `string_view(string&&)` breaks the primary use of `string_view` as a function argument. @kcc, you primarily work in an enormous codebase that calls this...

@kcc Have you done anything to get it removed from the codebases you've found the misuses in? What blocked you? Remember, I asked if it was a good tradeoff, not...

I did manually strip the `#include "cpp.html.h"`, assuming that was just to enable the mode where HTML works. The remaining difference in Chrome vs Safari is clearly a bug in...

Yes, `time git status` says about 0.5s of wall time. I don't expect to get a chance to learn git's internals well enough to fix this in the near future,...

I'm on a Macbook Pro at 2880 x 1800. Old: ![s7etvv1fvq](https://cloud.githubusercontent.com/assets/83420/5528527/11971604-89be-11e4-80f8-009b935e2163.png) New: ![odxeerlxk2](https://cloud.githubusercontent.com/assets/83420/5528552/5ea1b7ec-89be-11e4-9c19-519f9bb45d91.png) If we're treating github as the gold standard for readability, their [file list](https://github.com/w3c/respec/pull/373/files) has 26px entries vs...

I really want this for https://codereview.chromium.org/812853002/. I don't want to re-review the whole patch, just the changes since my review. It may be possible to identify points where the author...

cbor2diag.rb also loses the fact that integers are encoded with a non-minimal encoding. This comes at least partially from the fact that the cbor decoder represents integers and floating numbers...

In https://github.com/dimich-g/webpackage/pull/50/files#diff-04c6e90faac2675aa89e2176d2eec7d8R128, I'm requiring that the trailing length be encoded in 8 bytes, so that tools parsing from the end of the file can tell whether h'1b0000001a00191817' encodes 111670794263, 1644567,...

Yeah, that's fair. Another use, which I don't need yet, is for cases that require Canonical CBOR. If an item fails to parse due to being non-canonical, the diagnostic form...

That looks mostly good. We also need to be able to write things like `foo the bar with a baz of quux` where the parameter and argument have different names.