chromium-codereview icon indicating copy to clipboard operation
chromium-codereview copied to clipboard

Feature request: diff between patch(set)s

Open aarongable opened this issue 10 years ago • 4 comments

In the normal rietveld UI, you can diff against previous patchsets. This feature is particularly useful for multiple rounds of review (what have they changed since I last left comments?) and for relands, where you can re-upload the original CL as the first patchset and then your fix as the second patchset.

That doesn't appear to be possible in this UI.

aarongable avatar Jun 18 '14 20:06 aarongable

I don't think this feature is useful since it often has tons of rebase stuff in it. I don't think we should add it until there's more people asking.

esprehn avatar Jun 18 '14 21:06 esprehn

Ok, I'll get the whole infra team down here :) Seriously, we all use this feature every day.

The killer argument is: it is the only way to simultaneously see their responses to your comments, and the code changes they made along with those responses.

aarongable avatar Jun 18 '14 23:06 aarongable

I'll add this once Rietveld has a decent API for it. I don't want to do more screen scraping.

esprehn avatar Jun 20 '14 01:06 esprehn

I really want this for https://codereview.chromium.org/812853002/. I don't want to re-review the whole patch, just the changes since my review.

It may be possible to identify points where the author sync'ed and let people diff against that baseline (like the internal google code review tool does), but I'd be happy with just what Rietveld's old UI has.

jyasskin avatar Dec 20 '14 01:12 jyasskin