John Wiegley

Results 360 comments of John Wiegley

Hmmm... I needed this for dealing with a crypto ledger where I have tons of explicit lots, but I don't want to have to enumerate all of them in the...

One improvement I can see right away is to use a regex object for the account keys, rather than a string. The current implementation re-builds the reegex object (`std::regex`) every...

> @jwiegley I see several changes to the newly added `src/sha512.cc` file. I'd prefer to treat it as third-part code that is integrated into ledger verbatim (just like utfcpp) or...

@afh I've reverted all of my changes to the SHA512 code. What I would like to understand now is why the flake build here on GitHub fails, when it succeeds...

I was able to reproduce the build failure in a Linux VM, and found that all we're missing are two standard system headers.

> What are your thoughts on using one of the aforementioned libraries or another third-party implementation? I'm not really excited about new dependencies, they come with so many other costs...

I'm current awaiting a close review of `xact_t::hash` from @afh before merging this in.

My output is: ``` ledger-py3:[johnw@Vulcan:~/src/ledger/master]$ python3 test/RegressTests.py ~/Products/master/debug/ledger . ./test/regress/4D9288AE_py.test FAILURE in output from ./test/regress/4D9288AE_py.test: -- $ledger -f "/Users/johnw/src/ledger/master/test/regress/4D9288AE_py.test" python test/regress/4D9288AE.py -- @@ -1 +0,0 @@ -None FAILURE in error...

This is just a weakness of the budget reporting code, located here: https://github.com/ledger/ledger/blob/johnw%2Fdivzero/src/filters.cc#L1256 Multi-currency is a fundamental principle of Ledger, since I did not want anyone to be bound to...