John Wiegley

Results 360 comments of John Wiegley

I was unable to update this PR directly, so I've opened another PR with the same changes @fishyfriend.

Could you try putting this definition just *after* you load `use-package`: ```elisp (defun use-package-require (name &optional no-require body) (if use-package-expand-minimally (use-package-concat (unless no-require (list (use-package-load-name name))) body) (if no-require body...

@jmcardon Is it useful to keep this test, or should we close this?

This PR passed replay from genesis on my M1 Mac machine, and on my Intel Linux VM. @larskuhtz reports that `87bda99` passed replay from genesis on his Intel Linux machine.

We'd like for `/local` to become as close to an accurate preflight as possible, for debugging and development purposes. There are some changes currently in progress that ought to make...

If you're using the Emacs 26 pretest, I think it's just called `NEWS`, but sure, that's a good a place as any to start. :)

@t-wissmann Thank you for pointing this out! I'd happily accept a PR.

@patrick-nicodemus Hi Patrick, any further thoughts on this PR?

So we're just dropping the functoriality? I think that makes sense, as I cannot recall why I originally added that to the definition. I concur with your assessment.