Justin Mclean

Results 169 comments of Justin Mclean

@yuqi1129 seemed sure the files were copied from [here](https://packages.ubuntu.com/search?suite=oracular&section=all&arch=any&keywords=krb5-kdc&searchon=names), is that incorrect?

The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file.

The license can be obtain from their repo and includes the copyright line. See https://salsa.debian.org/debian/krb5/-/blob/master/NOTICE Copyright (C) 1985-2024 by the Massachusetts Institute of Technology. All rights reserved. Redistribution and use...

Note also that is a 2 clause BSD license not an MIT license.

It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of...

@zzzk1, I just checking you saw my feedback - there are only some minor corrections that need to be made.

@zhengkezhou1 thanks for your help with this. I just finished off the last little bit of work in #6666.

You ned to run `./gradlew :catalogs:catalog-hadoop:spotlessApply` and commit the changes to fix the CI issue.