gravitino [#6330] chore: add BSD license to missing files

What changes were proposed in this pull request?

Add BSD license to missing files

Why are the changes needed?

Fix: #6330

Does this PR introduce any user-facing change?

no

How was this patch tested?

no

Jan 22 '25 16:01 zhengkezhou1

Do we know where these files come from? ii.e. are they actually Apache licensed?

Jan 22 '25 21:01 justinmclean

They are just configuration files for Kerberos, which will be used for kerberized integrated test.

Jan 23 '25 12:01 jerryshao

@jerqi @yuqi1129 can you please help to review?

Jan 23 '25 12:01 jerryshao

Those files are template configuration files copied from Linux software kerberos-server which is under the MIT license, so in this case, I'm afraid that we can add an Apache license header here.

@justinmclean , About which license should we use, do you have more input?

Jan 23 '25 13:01 yuqi1129

Maybe we should keep MIT license top and append Apache license.

Jan 23 '25 14:01 zhengkezhou1

@yuqi1129 No, we cannot add an ASF license; if the code has another license, that license must be kept and not replaced unless you have permission from the original owners. If they are licensed under the MIT lisense then that also needs to be mentioned in the LICENSE file. Can you please give me a link to the original files, so I can check the license.

Jan 23 '25 22:01 justinmclean

I'm afraid that we can add an Apache license header here.

Sorry, the word should be we can't NOT we can.

Jan 24 '25 02:01 yuqi1129

@yuqi1129 No, we cannot add an ASF license; if the code has another license, that license must be kept and not replaced unless you have permission from the original owners. If they are licensed under the MIT lisense then that also needs to be mentioned in the LICENSE file. Can you please give me a link to the original files, so I can check the license.

The krb5-kdc can be found here.

Jan 24 '25 02:01 yuqi1129

I think we should add MIT license for kdc.conf, only one now.

Jan 24 '25 16:01 zhengkezhou1

See also https://infra.apache.org/licensing-howto.html#permissive-deps for what needs to be done to LICENSE (i.e. MIT license needs to be added).

Jan 24 '25 21:01 justinmclean

See also infra.apache.org/licensing-howto.html#permissive-deps for what needs to be done to LICENSE (i.e. MIT license needs to be added).

Can you provide an example of what we should do here? It's too vague here to just give a link. What I (we) want is the specific license content for those three files here.

Jan 26 '25 02:01 yuqi1129

Please be aware that these files are just Kerberos configuration files to make CI work, not the code copying from Kerberos source code.

Jan 26 '25 02:01 jerryshao

So where were the files copied from? At least one of them looks to come from https://salsa.debian.org/debian/krb5/-/blob/master/src/config-files/kdc.conf

Jan 26 '25 03:01 justinmclean

It is hard to say it is copied from other projects, because they all look the same.

Jan 26 '25 03:01 jerryshao

So the issue is:

These files were copied from somewhere but we're not 100% sure where from.
We can't put ASF headers on them as they are 3rd party code.
Because of 1 and 2 they need to be listed in LICENSE
They are most likely MIT licensed, but we're not 100% sure.

Jan 26 '25 03:01 justinmclean

@yuqi1129 seemed sure the files were copied from here, is that incorrect?

Jan 26 '25 03:01 justinmclean

@yuqi1129 seemed sure the files were copied from here, is that incorrect?

Yes, the files have been copied from the KDC software used in the Kerberized Hive Docker image. please see:

https://github.com/apache/gravitino/blob/ab85969a1bcd314ac4d6da6410b066e9455e209f/dev/docker/kerberos-hive/start.sh#L35-L61

Jan 26 '25 04:01 yuqi1129

The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file.

Jan 30 '25 04:01 justinmclean

The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file.

@justinmclean

I think you may need to provide a correct MIT license template as none of us are more familiar with it than you. I would be grateful if you could assist @zzzk1 in completing this PR. This PR has been hanging for a long time.

Feb 05 '25 08:02 yuqi1129

The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file.

@justinmclean

I think you may need to provide a correct MIT license template as none of us are more familiar with it than you. I would be grateful if you could assist @zzzk1 in completing this PR. This PR has been outstanding for a long time.

The promble stack me is that i don't know the right copyne name and date

licenses

The issue that concerns me is that I am unsure of the correct company and the creation date that are needed in the MIT license.

Feb 05 '25 08:02 zhengkezhou1

The license can be obtain from their repo and includes the copyright line. See https://salsa.debian.org/debian/krb5/-/blob/master/NOTICE

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Feb 06 '25 03:02 justinmclean

Note also that is a 2 clause BSD license not an MIT license.

Feb 06 '25 03:02 justinmclean

Thanks! btw should we include all of them in the file header?

Feb 14 '25 11:02 zhengkezhou1

It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of Technology" to the file. The full license text does need to be placed in the licenses directory and the LICENSE file updated to list it.

Feb 17 '25 05:02 justinmclean

It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of Technology" to the file. The full license text does need to be placed in the licenses directory and the LICENSE file updated to list it.

thanks got it.

Feb 17 '25 08:02 zhengkezhou1

@justinmclean please help to review again?

Feb 19 '25 04:02 jerryshao

@zzzk1, I just checking you saw my feedback - there are only some minor corrections that need to be made.

Feb 25 '25 05:02 justinmclean

@zhengkezhou1 thanks for your help with this. I just finished off the last little bit of work in #6666.

Mar 11 '25 07:03 justinmclean

Close this PR as it is already fixed in #6666 . Thanks @zhengkezhou1 for your work.

Mar 18 '25 11:03 jerryshao